udiskslinuxdriveata: Port to libblockdev SMART plugin #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbzatek
force-pushed
the
smart-1
branch
2 times, most recently
from
8b50633 to
164bd49
Compare
tbzatek
force-pushed
the
smart-1
branch
4 times, most recently
from
5dbd5a3 to
101a033
Compare
tbzatek
force-pushed
the
smart-1
branch
5 times, most recently
from
f51c6a4 to
beb434a
Compare
tbzatek
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
|
Jenkins, test this please. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Also, make the dependency on libblockdev-smart optional, the D-Bus API is ready for that. If unavailable, the org.freedesktop.UDisks2.Drive.Ata.SmartUpdated property will just stay zero forever.
|
Jenkins, test this please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completely untested, first draft that I'm completely not confident with. Lots of open questions regarding loosely-defined smartctl JSON output as well as loosely defined drivedb attribute names. Might be easier to implement compat drivedb parser for libatasmart perhaps?Needs storaged-project/libblockdev#835
TODO:
Fixes #433
Fixes #568