Skip to content
This repository has been archived by the owner on Nov 14, 2021. It is now read-only.

fix: workaround dependabot limitation by using two of them #21

Merged
merged 1 commit into from
Oct 16, 2020

Conversation

marcelltoth
Copy link
Contributor

Alright, so dependabot keeps complaining about my last PR #18 because it cannot handle having different schedules for different packages.

See the problem here:
dependabot/dependabot-core#1865

Maybe using Github's dependabot and the old one simultaneously does the trick. Let's see. I'm not sure this will work, but why not give it a try?

I'm not sure this works.

See the problem here:
dependabot/dependabot-core#1865

Maybe using Github's dependabot and the old one simultaneously does the trick. Let's see.
@marcelltoth marcelltoth requested a review from a team October 9, 2020 07:24
@marcelltoth marcelltoth self-assigned this Oct 9, 2020
Copy link
Contributor

@mmiask mmiask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Let's try that 🤞

I left one question about the directories, but nothing that would block merging this PR

version: 1
update_configs:
- package_manager: "javascript"
directory: "/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about all of the specified directories (both this config and github one) - I guess it includes all of the files and we don't need to specify a directory? (unless we have some parts of app with separate package.json that we don't want to bump )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe yes, that specifies the location of the package.json file

Copy link

@mallachari mallachari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No one knows unless we try it. Let's see :)

@marcelltoth marcelltoth merged commit 6bb0327 into main Oct 16, 2020
@marcelltoth marcelltoth deleted the fix/dependabot branch October 16, 2020 10:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants