-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use exponential backoff for s3 503 error #46
Conversation
|
||
describe('when there is no error', function () { | ||
it('uploads the file with one fetch call', async () => { | ||
mockFetch.mockResolvedValue({ ok: true } as Response); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should move this setup to a "beforeEach" block to be consistent across different tests within this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Seems likely we'll want to use a library for this at some point like https://www.npmjs.com/package/p-retry as we have more operations that require similar retry logic.
Good point. Will switch to use a library. |
This reverts commit 46fb00a.
I tried
I'd rather not deal with this right now. Created an issue: #47. |
Resolve #44.