Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports gets the instances managed by the Processor #391

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

iamsli
Copy link
Contributor

@iamsli iamsli commented Dec 12, 2024

per the spec Ports is defined as a link to the collection of the resource. In keeping with the pattern throughout the Gofish lib Ports() should return the instances of the Ports under processors. (Mostly I've copied the pattern established with client.serviceroot.Chassis() :)

Copy link
Owner

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@stmcginnis stmcginnis merged commit 78d6918 into stmcginnis:main Dec 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants