Swtich NetworkAdapter fields from common.LinksCollection to common.Link #329
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes a number of properties of the
NetworkAdapter
resource type (NetworkPorts
,Ports
,Processors
, etc.) to be parsed ascommon.Link
instead ofcommon.LinksCollection
. Meaning that each of these properties will now be parsed a single link to a collection resource rather than as an array of links.(For
NetworkDeviceFunctions
andNetworkPorts
, the flip fromcommon.LinksCollection
tocommon.Link
reverses the change that occurred in 646d2ab. The other properties were newly added to gofish.)This is necessary for
NewtworkAdapter
to parse correctly. Please correct me if I'm somehow confused here, but the spec for the latestNetworkAdapter
schema (https://redfish.dmtf.org/schemas/v1/NetworkAdapter.v1_10_0.json) states that all of these fields are single links, not arrays. (I think there may have been some confusion due toControllerLinks
having child properties with the same names that are in fact arrays, not single links, e.g. there isControllerLinks.NetworkPorts
which is an array).