Fix Chassis controls link definition #324
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Controls property of the Chassis object was incorrectly defined as a `common.Links` type, but it is actually a link to a collection, so it should be a `common.Link` (singular). This changes it to the Link type to avoid a JSON marshalling error on systems that populate this property. This also uncovered that the link that is used later to retrieve these controls was never actually being set. Both issues are now fixed. Signed-off-by: Sean McGinnis <[email protected]>
|
Being handled in #323 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Controls property of the Chassis object was incorrectly defined as a
common.Linkstype, but it is actually a link to a collection, so it should be acommon.Link(singular). This changes it to the Link type to avoid a JSON marshalling error on systems that populate this property.This also uncovered that the link that is used later to retrieve these controls was never actually being set. Both issues are now fixed.
Fixes: #322