Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new parameter MediaType to VirtualMediaConfig #290

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

Muyk33rus
Copy link
Contributor

we need to add a new parameter because without it an error occurs:
400: {
"[email protected]": [
{
"@odata.type": "#Message.v1_1_1.Message",
"Message": "The property MediaType is a required property and must be included in the request.",
"MessageArgs": [
"MediaType"
],
"MessageId": "Base.1.8.1.PropertyMissing",
"MessageSeverity": "Warning",
"Resolution": "Ensure that the property is in the request body and has a valid value and resubmit the request if the operation failed."
}
]
}

@Muyk33rus
Copy link
Contributor Author

@stmcginnis Can we merge this or are there any problems with this?

@stmcginnis
Copy link
Owner

Thanks, can you give a little more context on how/where you get this error?

This looks mostly good. The MediaType values are defined in the schema. Can you add that enum?

@Muyk33rus
Copy link
Contributor Author

Muyk33rus commented Dec 5, 2023

We are now testing mounting and unmounting images on the latest versions of https://gerrit.openbmc.org/plugins/gitiles/openbmc/openbmc/ and there just appeared an error when mounting if you do not specify the parameter MediaType.

We already have these enumerations, but why didn’t we use them in the config, I’ll fix it

Copy link
Owner

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Muyk33rus!

@stmcginnis stmcginnis merged commit 3d553d6 into stmcginnis:main Dec 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants