Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#24 Split integration tests by concept #27

Merged
merged 11 commits into from
Oct 29, 2016
Merged

#24 Split integration tests by concept #27

merged 11 commits into from
Oct 29, 2016

Conversation

tubbynl
Copy link
Contributor

@tubbynl tubbynl commented Oct 28, 2016 •
edited
Loading

pulling this before i'll dwell too much into extra tests and more refactoring :P

mentioning ticket #24 from the subject of this pull request alone didn't trigger ticket reference

tubbynl added 11 commits October 28, 2016 09:03
@tubbynl
stil4m#24 - moved assertWithin to TestUtil
1e43da1
@tubbynl
stil4m#24 - assertWithin using standard junit api
90aea44 
added fail messages
hamcrest Matchers.is=deprecated?
@tubbynl
unused imports
ef6dd1c
@tubbynl
stil4m#24 - moved Payments integration tests to PaymentsIntegrationTest
2844b86
@tubbynl
stil4m#24 - moved Methods integration tests to MethodsIntegrationTest
e0a26b8
@tubbynl
stil4m#24 - moved Issuers integration tests to IssuersIntegrationTest
7f424f2
@tubbynl
stil4m#24 - remainings tests were for Refunds, renamed to RefundsInte…
6706a2a 
…grationTest
@tubbynl
stil4m#24 - concept integration tests setup only the required concept…
08f3b49 
…s under test
@tubbynl
stil4m#24 - moved Payments integration tests to PaymentsIntegrationTest
f2b64ab 
merged duplicate tests
testGetPayment was identical
testCreatePayment was more complete in DynamicClientIntegrationTest (retained the DynamicClientIntegrationTest version)
@tubbynl
ClientBuilderTest and dynamicClient build using method reference or o…
ba8f574 
…rElse
@tubbynl
stil4m#24 assertWithin using hamcrest lessThanOrEqualTo
d8b1814
@stil4m
Copy link
Owner

stil4m commented Oct 29, 2016

Seems good. I'm gonna merge it and then I will resolve #25. There are some issues which I would like to resolve, but this is not the issue for that. See #28

@stil4m stil4m merged commit f97be10 into stil4m:master Oct 29, 2016
@tubbynl tubbynl deleted the feature/issue-24 branch October 31, 2016 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tubbynl @stil4m