Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow big offsets #363

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

BigFood2307
Copy link

Hi!

I always wanted the ability to use offsets bigger than half than my working width. For some implements this is necessary.

With these changes the current lane is now tracked relative to the offset line instead of the middle of the lane.
Of course the threshold in the GUI also needs to be removed for this to make any sense.

I did this for my self for mowing, but thought you might want to add it as well.
Not sure if this feature was intentionally not implemented before, just check it out if you want.

I did some testing for my self, and everything seems to be working as intended including offset reversal.

@FirenzeIT
Copy link

FirenzeIT commented Nov 18, 2024

Hello @BigFood2307, i use your updated, but when finish loading map, when i press ESC button, i have many errors, it's possible to fix them please??

2024-11-19 00:41 Error: Running LUA method 'update'.
dataS/scripts/gui/base/TabbedMenu.lua(489) : attempt to index field 'currentPage' (a nil value)
2024-11-19 00:41 Error: Running LUA method 'update'.
dataS/scripts/gui/base/TabbedMenu.lua(489) : attempt to index field 'currentPage' (a nil value)
2024-11-19 00:41 Error: Running LUA method 'update'.
dataS/scripts/gui/base/TabbedMenu.lua(489) : attempt to index field 'currentPage' (a nil value)
2024-11-19 00:41 Error: Running LUA method 'update'.
dataS/scripts/gui/base/TabbedMenu.lua(489) : attempt to index field 'currentPage' (a nil value)
2024-11-19 00:42 Error: Running LUA method 'update'.
dataS/scripts/gui/base/TabbedMenu.lua(489) : attempt to index field 'currentPage' (a nil value)
2024-11-19 00:42 Error: Running LUA method 'update'.
dataS/scripts/gui/base/TabbedMenu.lua(489) : attempt to index field 'currentPage' (a nil value)
2024-11-19 00:42 Error: Running LUA method 'update'.
dataS/scripts/gui/base/TabbedMenu.lua(489) : attempt to index field 'currentPage' (a nil value)
2024-11-19 00:42 Error: Running LUA method 'update'.
dataS/scripts/gui/base/TabbedMenu.lua(489) : attempt to index field 'currentPage' (a nil value)
2024-11-19 00:42 Error: Running LUA method 'update'.
dataS/scripts/gui/base/TabbedMenu.lua(489) : attempt to index field 'currentPage' (a nil value)
2024-11-19 00:42 Error: Running LUA method 'update'.
dataS/scripts/gui/base/TabbedMenu.lua(489) : attempt to index field 'currentPage' (a nil value)
2024-11-19 00:42 Error: Running LUA method 'update'.
dataS/scripts/gui/base/TabbedMenu.lua(489) : attempt to index field 'currentPage' (a nil value)
2024-11-19 00:42 Error: Running LUA method 'update'.

@BigFood2307
Copy link
Author

Hello @BigFood2307, i use your updated, but when finish loading map, when i press ESC button, i have many errors, it's possible to fix them please??

Hey!
Have you made sure that this is caused by this mod and specifically my version? Because the referenced "currentPage" variable is not used by my code at all. So it's much more likely to be a issue from somewhere else. I probably won't have time to do a lot of testing any time soon.

@FirenzeIT
Copy link

Hello @BigFood2307, i use your updated, but when finish loading map, when i press ESC button, i have many errors, it's possible to fix them please??

Hey! Have you made sure that this is caused by this mod and specifically my version? Because the referenced "currentPage" variable is not used by my code at all. So it's much more likely to be a issue from somewhere else. I probably won't have time to do a lot of testing any time soon.

Hi, yes i tried with modhub's version, directly from original author and from you, always this errors when i press ESC when finish loading map... I don't know why i have this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants