Some fixes and extra support #52
Conversation
Signed-off-by: Jeremy Compostella <[email protected]>
Signed-off-by: Jeremy Compostella <[email protected]>
I was getting a crash in the `concat' call of the `ox-jira-src-block' function on all my C src blocks. It turns out that `org-export-get-caption' is assuming that all the elements of the returned list are strings. It seems that only the first one is a string. Signed-off-by: Jeremy Compostella <[email protected]>
Handle verse blocks as Reformatted JIRA block. Signed-off-by: Jeremy Compostella <[email protected]>
|
Hello! Thank you for contributing! I want to start by apologising for taking so long to get back to you on this PR. I appear to have accidentally unsubscribed from this repo at some point. I'm now watching it, so should be able to keep up with requests. Regarding the PR itself:
|
| @@ -119,7 +119,7 @@ | |||
| (keyword . (lambda (&rest args) "")) | |||
| (latex-environment . (lambda (&rest args) (ox-jira--not-implemented 'latex-environment))) | |||
| (latex-fragment . (lambda (&rest args) (ox-jira--not-implemented 'latex-fragment))) | |||
| (line-break . (lambda (&rest args) (ox-jira--not-implemented 'line-break))) | |||
| (line-break . (lambda (&rest args) "\n\n")) | |||
There was a problem hiding this comment.
According to https://jira.atlassian.com/secure/WikiRendererHelpAction.jspa?section=breaks \\ should create a linebreak. I think that might be more accurate than \n\n, which appears to be a paragraph break?
| "Transcode a VERSE object from Org to Jira. | ||
| CONTENTS is verse block contents. INFO is a plist holding | ||
| contextual information." | ||
| (replace-regexp-in-string "^\\\(.*\\\)$" "{{\\1}}" contents)) |
There was a problem hiding this comment.
If I understand correctly this will render each line in monospaced font. WDYT about an explicit linebreak (using \\ at the end of each source line instead? That should have the same effect. Might also want to wrap it in a panel.
Although, I think JIRA keeps linebreaks, so you may be able to get away with just passing it through as-is. (I remember having to add code to the paragraph handler to remove linebreaks from the input for this reason.)
| "Transcode a CODE object from Org to JIRA. | ||
| CONTENTS is nil. INFO is a plist used as a communication | ||
| channel." | ||
| (org-element-property :utf-8 entity)) |
There was a problem hiding this comment.
🤔 What does this actually do? A test would really help here, as I don't know what this is for.
These patches addresses: