Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

switching to telnet and added support for the second zone #25

Merged
merged 9 commits into from
Mar 13, 2019
Merged

Conversation

stfnhmplr
Copy link
Owner

@stfnhmplr stfnhmplr commented Feb 25, 2019

@stfnhmplr stfnhmplr requested a review from luc-ass February 25, 2019 20:04
@luc-ass
Copy link
Collaborator

luc-ass commented Feb 25, 2019

I will happily review your code in the following days. How long has it been running at your place?

@stfnhmplr
Copy link
Owner Author

Since a few days. Did you tried it yet?

@vqv
Copy link

vqv commented Mar 8, 2019

I just installed a test the dev branch briefly with my Denon AVR-X3400H. In the Eve app I see two volume controls and two power switches: one pair for main and one pair for 2nd zone. I do not have a 2nd zone physically connected, but control of volume works for the main zone. I do not see input switching exposed anywhere. Is there a configuration option or is this absent from the plugin?

Edit Some more observations:

  • Mute works.
  • The plugin does not seem to be polling or something is wrong with it. If I power off the receiver, homebridge does not reflect this.

@NickChristensen
Copy link

I could help with this feature after this is merged and released, but it would be nice to make the second zone optional via configuration.

@stfnhmplr
Copy link
Owner Author

@vqv Thanks for testing. The selection of inputs will only be possible with the next version. I will adapt it to the new iOS version and removed the default input option for now.
Since the connection is established via Telnet, polling is no longer necessary. The receiver now reports a change back to the plugin via the Telnet connection. I just tried this again and it works for me. But I still added two more commands, maybe the receivers report the state in a different way.

@NickChristensen Thanks. That makes sense. The second Zone is now optional.

I think I will merge this PR tomorrow.

@stfnhmplr stfnhmplr merged commit c13b1eb into master Mar 13, 2019
@stfnhmplr stfnhmplr deleted the dev branch March 13, 2019 20:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants