Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Added rule to start the patch reboot workflow #288

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

Neonbluestoplight
Copy link
Contributor

Description:

Added a rule which starts the hv.patch.reboot action when the trigger hypervisor_state_change changes for a HV from "DRAINING" to "DRAINED"


Submitter:

Have you (where applicable):

  • Added unit tests?
  • Checked the latest commit runs on Dev?
  • Updated the example config file(s) and README?

Reviewer

Does this PR:

  • Place non-StackStorm code into the lib directory?
  • Have unit tests for the action/sensor and lib layers?
  • Have clear and obvious action parameter names and descriptions?

Runs the action if hypervisor_state_change changes from "DRAINING" to "DRAINED"
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.24%. Comparing base (a7c4041) to head (efd769a).
Report is 19 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #288   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files         239      239           
  Lines        9028     9028           
  Branches      529      529           
=======================================
  Hits         8870     8870           
  Misses        137      137           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lizsalmon lizsalmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@lizsalmon lizsalmon merged commit f947ef1 into main Nov 28, 2024
14 checks passed
@lizsalmon lizsalmon deleted the add_patch_workflow_rule branch November 28, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants