-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amphora image tweaks #38
Open
DavidFair
wants to merge
7
commits into
main
Choose a base branch
from
Amphora_image_tweaks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of configuring en-ZW for example, replace the default locale with en_US which is shipped anyway since these VMs are not user facing in any-way
Adds the output directory and any log.txt files from the build to the gitignore to ensure we don't pollute the git history with large or obsolete files
Switches the builder to use Ubuntu 22.04 Unfortunately, upstream disk image builder requires a fix as they use pkg_resources for 24.04 support, so bump a single version instead
Improves the various git clones for the amphora: - Use OpenDev directly for Octavia instead of a mirror - Set depth to 1 for all clones, since these are ephemeral
Update the upload step to use the dedicated output directory, instead of making the user manually cd to the correct place
DavidFair
force-pushed
the
Amphora_image_tweaks
branch
4 times, most recently
from
November 12, 2024 18:19
95ea0b5
to
991800f
Compare
Validates the qemu image then creates artifacts from the Github Actions including the SHA256 (which OpenStack can use as part of the image upload) as artifacts that stay around for ~1 week
DavidFair
force-pushed
the
Amphora_image_tweaks
branch
from
November 12, 2024 18:32
991800f
to
e11313e
Compare
meoflynn
reviewed
Nov 13, 2024
gmatthews20
approved these changes
Nov 13, 2024
Adds steps for enabling the Amphora image after uploading it
DavidFair
force-pushed
the
Amphora_image_tweaks
branch
from
November 19, 2024 14:52
849ea66
to
ea9462b
Compare
meoflynn
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds various tweaks to the Amphora build steps
See each commit for further details