Add our VM baseline to amphora images #31
Conversation
Fix permissions Set permissions after pull Fix line endings Add dependencies add full paths Move to later in the load order Set locale so ansible can run Different way of setting locale Output list of locales A different way of setting the locale print hostname Update playbooks to localhost before running Add gpg-agent for managing gpg keys Start GPG agent
amphora-image-builder/README
Outdated
There was a problem hiding this comment.
We should probably have this procedure in confluence as well if it isn't already
There was a problem hiding this comment.
@DavidFair to confirm?
There was a problem hiding this comment.
Yeah, I'm happy to move it - but I'd want a single copy either in the readme or confluence so they don't become out of sync
There was a problem hiding this comment.
A link to the readme from confluence with enough metadata to be searchable should be good
| @@ -0,0 +1,19 @@ | |||
| #!/bin/bash | |||
| #install ansible | |||
| /usr/bin/python3 -m pip install ansible | |||
There was a problem hiding this comment.
Could we use a venv, just because this will break in 22.04 onwards and it's bad to potentially trash the system packages anyway:
python3 -m venv /tmp/amphora-venv
source /tmp/amphora-venv/bin/activate
| /usr/bin/gpg-agent --daemon | ||
|
|
||
| hostname | ||
| sed -i "s/hosts: default/hosts: localhost/g" os_builders/*.yml |
There was a problem hiding this comment.
(I feel like there's something we can tweak in the os_builders dir to make this easier rather than using sed, but I'm drawing a blank currently...)
There was a problem hiding this comment.
Yeah, default includes localhost so it should work but doesnt
There was a problem hiding this comment.
Shellcheck required in the future - nothing critical/blocking at the moment
|
I've addressed David's comments but it will now fail to build the amphora in the tests due to requiring the content of this PR to be merged. |
|
@jacob-ward if you're happy with the changes after feel free to merge as the second reviewer |
Add our VM baseline to amphora images
Depends on #27