GH 37720:[Java][FlightSQL] Implement stateless prepared statement #1
Conversation
…ents Part fixed caching of statementContext
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or In the case of PARQUET issues on JIRA the title also supports: See also: |
stevelorddremio
changed the title
| SyncPutListener putListener = putParameters(descriptor, options); | ||
|
|
||
| try { | ||
| final PutResult read = putListener.read(); |
There was a problem hiding this comment.
Is it necessary to do this even in the case where no parameters were returned?
There was a problem hiding this comment.
On re-reading this, I'm not sure I understand your comment.
If no parameters are returned but parameters were set in parameterBindingRoot then it would be an error condition. The only way I can see we know if any parameters are returned from putParameters is if we read putListener. Did I miss something?
There was a problem hiding this comment.
I was thinking we shouldn't do parameter binding (line 1059) if we already got the parameter schema and it was empty.
There was a problem hiding this comment.
Ok, I can check for this.
java/flight/flight-sql/src/main/java/org/apache/arrow/flight/sql/FlightSqlClient.java
Show resolved
Hide resolved
java/flight/flight-sql/src/test/java/org/apache/arrow/flight/sql/example/FlightSqlExample.java
Outdated
Show resolved
Hide resolved
|
|
||
| try { | ||
| while (flightStream.next()) { | ||
| final VectorSchemaRoot root = flightStream.getRoot(); | ||
| final JdbcParameterBinder binder = JdbcParameterBinder.builder(preparedStatement, root).bindAll().build(); | ||
| binder = JdbcParameterBinder.builder(preparedStatement, root).bindAll().build(); |
There was a problem hiding this comment.
How are we dealing with old clients that don't yet support stateless prepared statements?
There was a problem hiding this comment.
If the server already supports stateful prepared statements, the parameters would continue to be cached on the server using the original handle. So old clients would continue to work. If the server stopped supporting stateful prepared statements, it would mean the client would need to be updated.
stevelorddremio
changed the title
No description provided.