Skip to content

Commit

Permalink
add nettypes, remove been_reset, add better comment
Browse files Browse the repository at this point in the history
  • Loading branch information
stevej committed Nov 5, 2024
1 parent b28431c commit 2626d77
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 14 deletions.
6 changes: 3 additions & 3 deletions src/byte_transmitter.v
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
// Given a byte, writes out 1 bit at a time while enable is high.
// Assumes the caller is tracking when 8 bits is sent.
module byte_transmitter (
(* gclk *) input clk,
input reset,
input enable,
(* gclk *) input wire clk,
input wire reset,
input wire enable,
// TODO: make size configurable
input wire [31:0] in, // byte_buffer
output wire out,
Expand Down
9 changes: 3 additions & 6 deletions src/jtag.v
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,6 @@ module jtag (
assign r_in_reset_from_main_clk = sync[1] & !sync[2];
*/

reg been_reset;

always @(negedge tck) begin
if (r_output_selector_transmitter) tap_channel <= 1'b0;
end
Expand All @@ -130,8 +128,7 @@ module jtag (
r_output_selector_transmitter <= 1'b1; // by default the tap controller writes
byte_transmitter_enable <= 1'b0;
reset_byte_transmitter <= 1'b0;
been_reset <= 1'b1;
end else if (enable && been_reset) begin
end else if (enable) begin
in_run_test_idle <= 1'b0;
in_select_dr_scan <= 1'b0;
in_capture_dr <= 1'b0;
Expand Down Expand Up @@ -216,7 +213,7 @@ module jtag (
default: begin
case (current_ir_instruction)
IdCode: begin
if (~idcode_out_done) begin
if (!idcode_out_done) begin
current_state <= ShiftDr;
end else begin
reset_byte_transmitter <= 1'b1;
Expand Down Expand Up @@ -337,7 +334,7 @@ module jtag (
end

//
// Checking that states are achievable via the documented Tap FSM
// Checking that the documented TAP FSM state transitions are achievable.
//
`HAPPENS_BEFORE(TestLogicReset, RunTestOrIdle)
`HAPPENS_BEFORE(RunTestOrIdle, RunTestOrIdle)
Expand Down
10 changes: 5 additions & 5 deletions src/minipit.v
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@
`default_nettype none

module minipit (
input clk,
input rst_n,
input enable,
input repeating,
input [15:0] counter,
input wire clk,
input wire rst_n,
input wire enable,
input wire repeating,
input wire [15:0] counter,
output wire interrupting
);

Expand Down

0 comments on commit 2626d77

Please sign in to comment.