Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle units with the same id at different points in a scenario #3

Open
stevecotton opened this issue Jan 25, 2023 · 1 comment · May be fixed by #4
Open

Handle units with the same id at different points in a scenario #3

stevecotton opened this issue Jan 25, 2023 · 1 comment · May be fixed by #4
Labels
bug Something isn't working

Comments

@stevecotton
Copy link
Owner

Found by @Toranks,

That is the case of UTBS S08, where the messenger knight id=messenger is always generated with the same id, although there are never two alive at the same time. It's a conflict with a mod that's the real problem, not the scenario.

Context is last night's discussion in the Discord #development / IRC #wesnoth-dev channel.

@stevecotton stevecotton added the bug Something isn't working label Jan 25, 2023
@Toranks
Copy link

Toranks commented Jan 26, 2023

If the idea is to prevent two units with the same id from being added to the array of wounded units, the solution is as simple as three extra lines here:

#define NFW_CATCH_LAST_BREATH
     [filter]
         [not]
             id=$nfw_exclude_unit_id
             [or]
                 find_in=nfw_wounded
             [/or]
         [/not]
     [/filter]

@Toranks Toranks linked a pull request Mar 25, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants