Fix h2spec test

stepancheg · Oct 28, 2018 · fd03305 · fd03305
1 parent 2ce05f6
commit fd03305
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/common/conn_read.rs b/src/common/conn_read.rs
@@ -236,7 +236,7 @@ where
                             // and the old value.
                             // TODO: check for overflow
                             s.out_window_size.0 += delta;
-                            s.pump_out_window.increase(delta as usize);
+                            s.pump_out_window.increase(delta as isize);
                         }
 
                         if !self.streams.map.is_empty() && delta > 0 {
@@ -313,7 +313,7 @@ where
         stream
             .stream()
             .pump_out_window
-            .increase(frame.increment as usize);
+            .increase(frame.increment as isize);
 
         Ok(Some(stream))
     }

diff --git a/src/common/window_size.rs b/src/common/window_size.rs
@@ -109,8 +109,9 @@ impl ConnOutWindowSender {
 }
 
 impl StreamOutWindowSender {
-    pub fn increase(&self, size: usize) {
-        assert!(size <= isize::max_value() as usize);
+    /// `size` can be negative when INITIAL_WINDOW_SIZE
+    /// setting changes to lower value.
+    pub fn increase(&self, size: isize) {
         let old_size = self
             .shared
             .window_size