-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/request param validation #1271
base: develop
Are you sure you want to change the base?
Conversation
Test Results 18 files - 43 18 suites - 43 6s ⏱️ -51s Results for commit 8b27814. ± Comparison against base commit ed38961. This pull request removes 887 and adds 4 tests. Note that renamed tests count towards both.
|
35469d6
to
7e1fb8e
Compare
7e1fb8e
to
9803a58
Compare
search-service/src/main/kotlin/com/egm/stellio/search/entity/service/EntityQueryService.kt
Outdated
Show resolved
Hide resolved
shared/src/main/kotlin/com/egm/stellio/shared/model/parameter/GeoQuery.kt
Outdated
Show resolved
Hide resolved
config/detekt/detekt.yml
Outdated
@@ -733,7 +733,7 @@ style: | |||
active: true | |||
UnusedParameter: | |||
active: true | |||
allowedNames: 'ignored|expected' | |||
allowedNames: 'ignored|expected|params' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK but better if renamed to queryParams
to make it very clear what it is about (and avoid others to use the "gap")
search-service/src/main/kotlin/com/egm/stellio/search/entity/web/EntityHandler.kt
Outdated
Show resolved
Hide resolved
const val AGGRMETHODS_PARAM = "aggrMethods" | ||
const val LASTN_PARAM = "lastN" | ||
const val TIMEPROPERTY_PARAM = "timeproperty" | ||
const val WHOLE_TIME_RANGE_DURATION = "PT0S" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WHOLE_TIME_RANGE_DURATION
is not a query param (just a special value we have to take care of when calculating aggregations, more like an implementation detail)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes i put it in TemporalQueryUtils instead. (because it is only used by search service)
shared/src/main/kotlin/com/egm/stellio/shared/web/ExceptionHandler.kt
Outdated
Show resolved
Hide resolved
shared/src/main/kotlin/com/egm/stellio/shared/web/ExceptionHandler.kt
Outdated
Show resolved
Hide resolved
...tion-service/src/main/kotlin/com/egm/stellio/subscription/job/TimeIntervalNotificationJob.kt
Outdated
Show resolved
Hide resolved
shared/src/main/kotlin/com/egm/stellio/shared/model/parameter/QueryParameter.kt
Outdated
Show resolved
Hide resolved
5c9fe84
to
a5abbf0
Compare
Still need to add the annotation to all the endpoints.