Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/request param validation #1271

Draft
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

thomasBousselin
Copy link
Contributor

Still need to add the annotation to all the endpoints.

@github-actions github-actions bot added the feature New feature or request label Nov 27, 2024
Copy link
Contributor

Test Results

 18 files   -  43   18 suites   - 43   6s ⏱️ -51s
209 tests  - 727  209 ✅  - 726  0 💤 ±0  0 ❌  - 1 
209 runs   - 766  209 ✅  - 765  0 💤 ±0  0 ❌  - 1 

Results for commit 8b27814. ± Comparison against base commit ed38961.

This pull request removes 887 and adds 4 tests. Note that renamed tests count towards both.
                                    { "id":…, withTemporalValues=true, withAudit=false, expectation={
                      "@id": "https://uri…
                      "@type": "@json",
                      …
                    "@value": "/A/B"
                    "@value": "/C/D"
                    "@value": 20
                    "…
                    {
                  "@type": "https://uri.etsi.org/ngsi-ld/DateTime",
…
com.egm.stellio.shared.model.LanguageFilterTests ‑ [1] nl, "languageProperty": {
    "type": "Property",
    "value": "Grote Markt",
    "lang": "nl"
}
com.egm.stellio.shared.model.LanguageFilterTests ‑ [2] en, "languageProperty": {
    "type": "Property",
    "value": "Big Place",
    "lang": "@none"
}
com.egm.stellio.shared.model.LanguageFilterTests ‑ [3] *, "languageProperty": {
    "type": "Property",
    "value": "Big Place",
    "lang": "@none"
}
com.egm.stellio.shared.model.LanguageFilterTests ‑ [4] fr-CH,fr;q=0.9,en;q=0.8,*;q=0.5, "languageProperty": {
    "type": "Property",
    "value": "Grand Place",
    "lang": "fr"
}

@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2024
@@ -733,7 +733,7 @@ style:
active: true
UnusedParameter:
active: true
allowedNames: 'ignored|expected'
allowedNames: 'ignored|expected|params'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK but better if renamed to queryParams to make it very clear what it is about (and avoid others to use the "gap")

const val AGGRMETHODS_PARAM = "aggrMethods"
const val LASTN_PARAM = "lastN"
const val TIMEPROPERTY_PARAM = "timeproperty"
const val WHOLE_TIME_RANGE_DURATION = "PT0S"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WHOLE_TIME_RANGE_DURATION is not a query param (just a special value we have to take care of when calculating aggregations, more like an implementation detail)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes i put it in TemporalQueryUtils instead. (because it is only used by search service)

shared/src/main/resources/shared.properties Outdated Show resolved Hide resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants