Merge pull request #12 from stellarwp/feat/float-datetime

Adding float as valid type.
stellarwp · Sep 9, 2024 · 6d0d833 · 6d0d833
2 parents 7c21d23 + 478549e
commit 6d0d833
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/src/Models/Model.php b/src/Models/Model.php
@@ -328,6 +328,10 @@ public function isPropertyTypeValid( string $key, $value ) : bool {
 				return is_bool( $value );
 			case 'array':
 				return is_array( $value );
+			case 'float':
+				return is_float( $value );
+			case 'number':
+				return is_int( $value ) || is_float( $value );
 			default:
 				return $value instanceof $type;
 		}

diff --git a/tests/_support/Helper/MockModel.php b/tests/_support/Helper/MockModel.php
@@ -6,9 +6,11 @@
 
 class MockModel extends Model {
 	protected $properties = [
-		'id'        => 'int',
-		'firstName' => [ 'string', 'Michael' ],
-		'lastName'  => 'string',
-		'emails'    => [ 'array', [] ],
+		'id'           => 'int',
+		'firstName'    => [ 'string', 'Michael' ],
+		'lastName'     => 'string',
+		'emails'       => [ 'array', [] ],
+		'microseconds' => 'float',
+		'number'       => 'number',
 	];
 }
diff --git a/tests/wpunit/ModelTest.php b/tests/wpunit/ModelTest.php
@@ -306,6 +306,8 @@ public function invalidTypeProvider() {
 			[ 'id', 'Not an integer' ],
 			[ 'firstName', 100 ],
 			[ 'emails', 'Not an array' ],
+			[ 'microseconds', 'Not a float' ],
+			[ 'number', '12' ] // numeric strings do not work; must be int or float
 		];
 	}
 }