-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add getLedgers
implementation
#303
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaptic
reviewed
Sep 28, 2024
Shaptic
reviewed
Sep 28, 2024
Shaptic
reviewed
Sep 28, 2024
Shaptic
reviewed
Sep 28, 2024
Shaptic
reviewed
Sep 28, 2024
Co-authored-by: George <[email protected]>
Co-authored-by: George <[email protected]>
Shaptic
reviewed
Oct 7, 2024
Shaptic
reviewed
Oct 7, 2024
Shaptic
reviewed
Oct 7, 2024
Based on this thread, should we rename |
Should we cherry-pick this onto the |
Co-authored-by: George <[email protected]>
2opremio
reviewed
Nov 4, 2024
2opremio
reviewed
Nov 4, 2024
@aditya1702 The PR looks really good! We should resolve the problem of the response ledger range potentially being inconsistent with the ledgers in the response. |
Co-authored-by: Alfonso Acosta <[email protected]>
aditya1702
force-pushed
the
get-ledgers
branch
from
November 8, 2024 18:32
9a97072
to
526b534
Compare
…dgers # Conflicts: # cmd/soroban-rpc/internal/config/main.go # cmd/soroban-rpc/internal/jsonrpc.go
tamirms
reviewed
Nov 8, 2024
tamirms
reviewed
Nov 8, 2024
tamirms
reviewed
Nov 12, 2024
tamirms
approved these changes
Nov 13, 2024
This was referenced Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #111
Adding new endpoint -
getLedgers
. It has the following request structure:and the response structure:
Pagination functionality is similar to
getTransactions
andgetEvents
.Why
This endpoint allows users to access ledger-level info more easily and enables common use-cases: examining ledger sequence numbers, time of close/finality, fees, or getting a snapshot of the ledger at that point in time. For more info refer to the discussion on the original issue ticket.
Benchmarking Details
BatchGetLedgers
: Fetches ledgers in batches from the DB. Note that I have used a batch size of 200 for benchmarking as that is the max ledgers request limit we have set forgetLedgers
endpoint.GetLedgers
: The RPC endpoint to get ledgers.