Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keys: valid keys when added #1812

Merged
merged 10 commits into from
Dec 20, 2024
Merged

keys: valid keys when added #1812

merged 10 commits into from
Dec 20, 2024

Conversation

leighmcculloch
Copy link
Member

What

Validate secret keys and seed phrases when adding.

Why

Close #1805

@leighmcculloch leighmcculloch marked this pull request as ready for review December 19, 2024 06:03
@leighmcculloch leighmcculloch changed the title keys: add does not validate keys keys: valid keys when added Dec 19, 2024
cmd/soroban-cli/src/config/secret.rs Outdated Show resolved Hide resolved
@leighmcculloch leighmcculloch enabled auto-merge (squash) December 20, 2024 08:17
@leighmcculloch leighmcculloch merged commit a5f0259 into main Dec 20, 2024
28 of 31 checks passed
@leighmcculloch leighmcculloch deleted the i1805 branch December 20, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

keys: add does not validate keys
4 participants