Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve deploy docs #1416

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Improve deploy docs #1416

merged 1 commit into from
Dec 13, 2024

Conversation

leighmcculloch
Copy link
Member

@leighmcculloch leighmcculloch commented Dec 13, 2024

What

Remove the let _ = deployer.deployed_address(); line from the two existing deploy examples that are in the rust docs, and add an example that discusses the deployer.deployed_address() in more detail.

Screenshot 2024-12-13 at 11 07 22 pm

Why

Plopping the let _ = deployer.deployed_address(); into the middle of an example that's about a specific scenario is distracting as to the main purpose of the example. The docs can show how to use the function in an example focused on it specifically.

@leighmcculloch leighmcculloch requested a review from a team December 13, 2024 13:06
@leighmcculloch leighmcculloch marked this pull request as ready for review December 13, 2024 13:08
Copy link
Contributor

@dmkozh dmkozh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@leighmcculloch leighmcculloch added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit e176daa Dec 13, 2024
17 checks passed
@leighmcculloch leighmcculloch deleted the deploy-docs branch December 13, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants