quickstart: add soroban high limit override for standalone networks #480
Conversation
tsachiherman
changed the title
start
Outdated
| @@ -53,6 +54,10 @@ function main() { | |||
| echo "--randomize-network-passphrase is only supported in the standalone network" >&2 | |||
| exit 1 | |||
| fi | |||
| if [ "$NETWORK" != "standalone" ] && [ "$ENABLE_SOROBAN_HIGH_LIMIT_OVERRIDE" = "true" ]; then | |||
There was a problem hiding this comment.
might be more apt to validate usage with $ENABLE_SOROBAN_RPC" != "true"? regardless of network.
There was a problem hiding this comment.
I don't think so. This feature is accessible independent of whether the soroban-rpc is running.
There was a problem hiding this comment.
the new --enable-soroban-high-limit-override flag should be mentioned on soroban rpc section in readme as well, so users are aware - https://github.com/stellar/quickstart#soroban-development
|
@tsachiherman Had a new thought on this. Given that standalone is the dev+testing mode, and we already accelerate ledgers even for it, maybe we should enable this by default always and have no option. Or, have an option to enable limits. Either having no option, or one to enable limits, are probably a more useful default. We want people to have a great experience upfront which means running their contracts irrespective of limits. And then be able to become experts and know how to write small contracts and then test that they are sufficiently small. |
I was tempted to ask the same, and then figured that users will need to be able to replicate test cases under both modes correct? so, figured it was worth having the command line flag, like your other suggestion also of default high limit to enabled for seamless experience |
|
It just occurred to me that adding a setting won't be useful today, because the default limits are so low the soroban functionality is largely unusable. As such this flag will practically only be an on off switch for soroban rather than a control of limits. Apologies for flipping on this, but I think we should reduce this to a hardcoded value of on for standalone, since it's primary use case is testing. Once the stellar-core team finish the below issue, converting the Python upgrade script into a more portable command, we should revisit adding an option, maybe an option that lets the user set pubnet limits rather than the default super low and largely not useful default limits. |
|
I'm closing this PR in favor of #492 |
What ?
With the recent core build, the resource limits for soroban transactions were lowered dramatically.
On any of the public networks, there would be a process to raise these up to a reasonable values.
However, for standalone networks, there is no such "entity".
In order to bootstrap a network that is usable, we need to add the TESTING_SOROBAN_HIGH_LIMIT_OVERRIDE flag to any core node invocation.
This PR adds the option to enable setting the above flag on standalone network.
Note that it might be arguable that it's always desired on a standalone network - but that's TBD.