Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Dependency Check to 9.0.6 so synchronization works again #19

Merged

Conversation

Jurrie
Copy link
Contributor

@Jurrie Jurrie commented Dec 18, 2023

  • Bumped MySQL Docker image to 8.0.31 (according to this users are encouraged to upgrade to MySQL 8.0).
  • Bumped the MySQL JDBC driver to com.mysql:mysql-connector-j:8.2.0.
  • Bumped OWASP Dependency Check to 9.0.6. This makes synchronization work again.

I currently experience a lot of SQLException: Incorrect string value: '\xEF\xBF\xBDboa...' for column 'p_shortDescription' at row 1 in my /dependencycheck/update.log file. I also read that that NVD is deprecating their old RSS feeds. To use their newer API you should use the 9.x versions of OWASP Dependency Check. And with the 9.x version I don't have a synchronization issue anymore, so I consider it fixed 😀

@Jurrie Jurrie changed the title Feature/bump dependency check to 9.0.6 Bump Dependency Check to 9.0.6 so synchronization works again Dec 18, 2023
@Jurrie Jurrie marked this pull request as ready for review December 18, 2023 10:56
@Jurrie Jurrie force-pushed the feature/bump_dependency_check_to_9.0.6 branch from 0ea73cc to a834459 Compare December 18, 2023 18:35
@stefanneuhaus
Copy link
Owner

Hey @Jurrie, thank you very much! I just had a first quick look. It looks very thoroughly crafted, you did some nice cleanup as well.
I remember having considered doing the MySQL some time ago, but run into a performance regression. Did you compare the running times for updating the database?
I plan to do the full review and give it a test run during the next weekend. Busy times at work a.t.m., so please bear with me.

@Jurrie
Copy link
Contributor Author

Jurrie commented Dec 18, 2023

Hey @stefanneuhaus! No, I did not compare running times for database updates. I know the initial database sync of this new Docker image took 54:17 on my laptop. I see my current production Docker image (version 8.0.0) took 48:00. Would seem comparable at first, but keep in mind that my laptop is a lot faster than the production VM and it runs a newer Docker version. Maybe you are able to check this when you do a full review?

Copy link
Owner

@stefanneuhaus stefanneuhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @Jurrie , very much appreciated!

@stefanneuhaus stefanneuhaus merged commit 00f3360 into stefanneuhaus:main Dec 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants