add in_subtree_of? helper function, for symmetry #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbrock
reviewed
Jun 12, 2024
kbrock
requested changes
Jun 12, 2024
Roguelazer
force-pushed
the
in_subtree_of
branch
from
fbeadd1 to
48c0a9f
Compare
|
The sqlite3 > 2.0 thing is breaking this build. Putting together a PR that fixes this (i.e.: #681), then will kick this build and merge. Thanks for the contribution |
|
kicking (fixed build) |
Roguelazer
force-pushed
the
in_subtree_of
branch
from
48c0a9f to
b594e99
Compare
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an
in_subtree_of?method, because I've written this code many times and figured it made sense upstream.