Add virtual depth column support #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbrock
force-pushed
the
virtual_depth
branch
from
db822ad to
0c6a033
Compare
kbrock
changed the title
kbrock
force-pushed
the
virtual_depth
branch
3 times, most recently
from
86b733e to
0033a50
Compare
still need to consider whether to keep depth_cache_column as deprecated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in response to #662 and more of a conversation starter
I had wanted to deprecate one of these options, but in this case, it looks like having a separate option for column name would be helpful in some instances.
@mitsuru would this meet your needs or do you have other ideas?