Remove non-geo phone numbers from the SplitPhoneNumberWidget #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The COUNTRY_CODE_TO_REGION_CODE dict contains values that are not specific to a region code: the COUNTRY_CODES_FOR_NON_GEO_REGIONS. These country codes are international, and are not a good fit for the SplitPhoneNumberWidget, which offers to select a region, then fill in the national number.
stefanfoulis
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
COUNTRY_CODE_TO_REGION_CODEdict contains values that are not specific to a region code: theCOUNTRY_CODES_FOR_NON_GEO_REGIONS. These country codes are international, and are not a good fit for theSplitPhoneNumberWidget, which offers to select a region, then fill in the national number.Fixes #605