-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sanitise README and tests to help other contributors #13
base: master
Are you sure you want to change the base?
Conversation
ashleyfrieze
commented
Nov 8, 2020
- fix minor typos
- allow tests to pass when run in IntelliJ (avoid unrunnable test classes)
- enhance info about building and running tests
- fix minor typos - allow tests to pass when run in IntelliJ (avoid unrunnable test classes) - enhance info about building and running tests
@@ -7,7 +7,7 @@ | |||
import static com.github.stefanbirkner.fishbowl.Fishbowl.ignoreException; | |||
import static org.assertj.core.api.Assertions.assertThat; | |||
|
|||
class RestoreSystemErrChecks { | |||
abstract class RestoreSystemErrChecks { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a test base class and JUnit5 cannot run it. If marked abstract
the IDE won't try to run it either. Obviously, its name prevents it being run by surefire, but this covers both angles.
If a test base class cannot be run directly, then it should be As we discussed in #9, I'm forking out this codebase to create something which allows many more patterns of invocation. As I do so, I'll try to contribute back any fixes for glitches that I find in the core code. It's up to you whether you include them, but it's only fair to pay you back with any improvements that translate into your paradigm. |
d3ce0eb
to
5e206a7
Compare