Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editor not loading in, move Three to npm dependency #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Degubi
Copy link
Contributor

@Degubi Degubi commented Jan 11, 2022

My motivation behind this change is to be able to update to newer three.js versions later.

The first commit removes the usage of 'top' from editor.js, because it was causing a cross origin error which made the editor not load in.
This is a temporary fix

Second commit:

  • Add three.js npm dependency
  • Remove three.js files from 'media' folder (still keep editor files)
  • Update three.js from r89 to r93 (last version which had a @types package before getting removed, then re-added later in r131

@Degubi Degubi changed the title Three to npm dependency Fix editor not loading in, move Three to npm dependency Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant