Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework background color & image handling #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rework background color & image handling #25

wants to merge 1 commit into from

Conversation

Degubi
Copy link
Contributor

@Degubi Degubi commented Jan 10, 2022 •
edited
Loading

  • Rename existing 'background' property to 'backgroundColor'
  • Add new setting 'backgroundImage' with values:
    • 'none' means disabled (backgroundColor gets used)
    • some other cube images that could be found in the textures/cube directory
  • Fix some issues regarding background color changing. Previously when changing the background color it would disappear and the body element's green background would show up.
  • Remove green background flash while loading in
  • Re-organize functions in viewer.js, so that all user input handling functions are at the same place

@Degubi Degubi force-pushed the background-update branch from 99ea0cd to ad2e15f Compare January 10, 2022 16:18
@Degubi Degubi force-pushed the background-update branch from ad2e15f to 877957f Compare January 10, 2022 16:19
@Degubi Degubi mentioned this pull request Jan 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Degubi