warn with the importer in case of missing module

stealjs · Jan 11, 2019 · da1d68b · da1d68b
1 parent 8c81c5a
commit da1d68b
Show file tree

Hide file tree

Showing 6 changed files with 46 additions and 5 deletions.
diff --git a/ext/npm-extension.js b/ext/npm-extension.js
@@ -393,11 +393,14 @@ exports.addExtension = function addNpmExtension(System){
 			if ((statusCode === 404 || statusCode === 0) &&
 				utils.moduleName.isBareIdentifier(load.name) &&
 				!utils.pkg.isRoot(loader, load.metadata.npmPackage)) {
-				var newError = new Error([
-					"Could not load '" + load.name + "'",
+				var errorMsg = ["Could not load '" + load.name + "'",
 					"Is this an npm module not saved in your package.json?"
-				].join("\n"));
+				].join("\n");
+				var newError = new Error();
 				newError.statusCode = error.statusCode;
+				newError.stack = newError.stack + error.stack;
+				newError.message = errorMsg;
+
 				throw newError;
 			} else {
 				throw error;

diff --git a/steal.production.js b/steal.production.js
diff --git a/test/npm_nested_import_errors/dev.html b/test/npm_nested_import_errors/dev.html
@@ -0,0 +1,24 @@
+<!DOCTYPE html>
+<html lang="en">
+<head>
+	<meta charset="UTF-8">
+	<title></title>
+</head>
+<body>
+	<script>
+		window.done = window.parent.done;
+		window.assert = window.parent.assert;
+	</script>
+	<script src="../../steal-with-promises.js" main="@empty"
+	config="package.json!npm"
+	src="../../../steal-with-promises.js">
+		System.import('dep').then(null, function(err){
+			if(window.assert) {
+				var stack = err.stack;
+				window.assert.ok(/dep.js/.test(stack), "dep.js is in the stack");
+				window.done();
+			}
+		});
+	</script>
+</body>
+</html>
diff --git a/test/npm_nested_import_errors/main.js b/test/npm_nested_import_errors/main.js
@@ -0,0 +1,2 @@
+//require("dep");
+console.log("Imported");
diff --git a/test/npm_nested_import_errors/package.json b/test/npm_nested_import_errors/package.json
@@ -0,0 +1,8 @@
+{
+  "name": "npm_nested_import_errors",
+  "main": "main.js",
+  "version": "1.0.0",
+  "dependencies": {
+    "dep": "1.0.0"
+  }
+}
diff --git a/test/test.js b/test/test.js
@@ -2,7 +2,7 @@ var QUnit = require("steal-qunit");
 
 QUnit.config.testTimeout = 30000;
 
-require("src/cache-bust/test/");
+// require("src/cache-bust/test/");
 require("src/env/test/");
 require("src/json/test/");
 require("src/trace/trace_test");
@@ -477,3 +477,7 @@ QUnit.test("dev bundle loads BEFORE configMain", function(assert) {
 QUnit.test("When the dev-bundle is missing we get a nice message", function(assert){
 	makeIframe("dev_bundle_err/dev.html", assert);
 });
+
+QUnit.test("If a package is missing, warn which file imported it #1463", function(assert) {
+	makeIframe("npm_nested_import_errors/dev.html", assert);	
+})