Merge pull request #1493 from stealjs/1463-npm-import-warn-with-importer

warn with the importer in case of missing module
stealjs · Jan 15, 2019 · 13b376b · 13b376b
2 parents 8c81c5a + 344bf2c
commit 13b376b
Show file tree

Hide file tree

Showing 7 changed files with 38 additions and 1 deletion.
diff --git a/ext/npm-extension.js b/ext/npm-extension.js
@@ -398,6 +398,7 @@ exports.addExtension = function addNpmExtension(System){
 					"Is this an npm module not saved in your package.json?"
 				].join("\n"));
 				newError.statusCode = error.statusCode;
+				newError.stack = newError.stack + error.stack;
 				throw newError;
 			} else {
 				throw error;

diff --git a/steal.production.js b/steal.production.js
diff --git a/test/npm_nested_import_errors/dep.js b/test/npm_nested_import_errors/dep.js
@@ -0,0 +1,2 @@
+module.exports = {};
+require("~/foo");
diff --git a/test/npm_nested_import_errors/dev.html b/test/npm_nested_import_errors/dev.html
@@ -0,0 +1,22 @@
+<!DOCTYPE html>
+<html lang="en">
+<head>
+	<meta charset="UTF-8">
+	<title></title>
+</head>
+<body>
+	<script>
+		window.done = window.parent.done;
+		window.assert = window.parent.assert;
+	</script>
+	<script src="../../steal-with-promises.js" 
+		config="package.json!npm"
+		main="@empty">
+		steal.import('~/main').then(null, function(err){
+			var stack = err.stack;
+			window.assert.ok(/dep.js/.test(stack), "dep.js is in the stack");
+			window.done();
+		})
+	</script>
+</body>
+</html>
diff --git a/test/npm_nested_import_errors/main.js b/test/npm_nested_import_errors/main.js
@@ -0,0 +1,3 @@
+module.exports = {};
+require('~/dep');
+
diff --git a/test/npm_nested_import_errors/package.json b/test/npm_nested_import_errors/package.json
@@ -0,0 +1,5 @@
+{
+  "name": "npm_nested_import_errors",
+  "main": "main.js",
+  "version": "1.0.0"
+}
diff --git a/test/test.js b/test/test.js
@@ -477,3 +477,7 @@ QUnit.test("dev bundle loads BEFORE configMain", function(assert) {
 QUnit.test("When the dev-bundle is missing we get a nice message", function(assert){
 	makeIframe("dev_bundle_err/dev.html", assert);
 });
+
+QUnit.test("If a package is missing, warn which file imported it #1463", function(assert) {
+	makeIframe("npm_nested_import_errors/dev.html", assert);	
+})