PHPStan level 2

[SanderMuller]

No description provided.

[staudenmeir]

@SanderMuller Do you have any idea how to solve these errors?

I tried type-hinting the ancestorPost relationship with @return \Staudenmeir\EloquentHasManyDeep\HasOneDeep<Post>, but PHPStan still thinks that the result is a collection.

[SanderMuller]

@SanderMuller Do you have any idea how to solve these errors?

I tried type-hinting the ancestorPost relationship with @return \Staudenmeir\EloquentHasManyDeep\HasOneDeep<Post>, but PHPStan still thinks that the result is a collection.

We could either add ignore statements, baseline them or add @var docblocks at each usage. I guess PHPStan can just infer that it's a collection of models based on the Staudenmeir\EloquentHasManyDeep\HasOneDeep relation which extends HasManyDeep which extends HasManyThrough, so it's based on a one on many relation. You could refactor HasOneDeep to extend HasOneThrough and use trais for the common logic instead of inheritance.

Let me know which direction you want to take, then I can take a look

[SanderMuller]

@staudenmeir I've resolved it for now via 1bee685

Keep in mind that users of the package(s) might encounter the same challenge if the cause isn't solved

[staudenmeir]

Thanks @SanderMuller.

I guess PHPStan can just infer that it's a collection of models based on the Staudenmeir\EloquentHasManyDeep\HasOneDeep relation which extends HasManyDeep which extends HasManyThrough, so it's based on a one on many relation.

It's unfortunate that @extends \Illuminate\Database\Eloquent\Relations\HasOneThrough<TRelatedModel> in the HasOneDeep relation doesn't override that.

You could refactor HasOneDeep to extend HasOneThrough and use trais for the common logic instead of inheritance.

I want to avoid that because it would be a breaking change. Laravel recently refactored the HasOneThrough relation in a similar way and it broke code in my packages.

[staudenmeir]

Thanks for this great contribution! I released a new version.

[SanderMuller]

Thanks for this great contribution! I released a new version.

🎉 thank you for the time and effort you put into this