Relation generics and PHPStan lvl 9

[SanderMuller]

Similar to the work on https://github.com/staudenmeir/laravel-adjacency-lis I've introduced generic support for the BelongsToThrough relation, and increasing PHPStan to the max level was quite easy!

[staudenmeir]

Awesome, thanks!

[staudenmeir]

@SanderMuller FYI: PHPStan released v1.12.1 yesterday and that suddenly reports the return type getRelationExistenceQuery() as invalid (it's not caused by my changes in 949c7d9):
https://github.com/staudenmeir/belongs-to-through/actions/runs/10697087338/job/29653550927

Not sure if that's a bug or PHPStan just hadn't been able to properly analyze the Eloquent and Query Builder construct until now.

I fixed it with a @var comment for now: 7a9f8b4

[SanderMuller]

@SanderMuller FYI: PHPStan released v1.12.1 yesterday and that suddenly reports the return type getRelationExistenceQuery() as invalid (it's not caused by my changes in 949c7d9): https://github.com/staudenmeir/belongs-to-through/actions/runs/10697087338/job/29653550927

Not sure if that's a bug or PHPStan just hadn't been able to properly analyze the Eloquent and Query Builder construct until now.

I fixed it with a @var comment for now: 7a9f8b4

Weird $query->select() seems to already trigger a "downgrade" of the inferred type to Illuminate/Database/Query/Builder instead of retaining \Illuminate\Database\Eloquent\Builder<\Illuminate\Database\Eloquent\Model> despite the select() method returning $this, which should AFAIK keep its caller scope. I first thought maybe the Laravel Framework made a change, but it indeed seems to be related to the latest PHPStan update, though I'm not sure why. There's quite some changes in phpstan/phpstan-src@1.12.0...1.12.1 😅 maybe we should accept your fix for now

[staudenmeir]

There's quite some changes in phpstan/phpstan-src@1.12.0...1.12.1

Yeah... My best guess would be that it's related to one of the commits about mixins.

[SanderMuller]

There's quite some changes in phpstan/[email protected]

Yeah... My best guess would be that it's related to one of the commits about mixins.

I'm actually getting the same PHPStan errors on my other projects. This seems to be the related issue phpstan/phpstan#11624 and larastan/larastan#2032, mixins are indeed mentioned there

[calebdw]

Looks like I was a little late to catch this before it was merged, but here's some suggested improvements