Adjust discv5_updateNodeInfo JSON-RPC to specify key and value #1569
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accompanying spec PR: ethereum/portal-network-specs#207
The current version was not following the spec, but also not the above spec PR, as a nameless tuple basically required the parameter to look like:
Which now becomes:
I don't think there is some way to define a Nim type that results in something like:
I think that requires custom parsing of the
JsonNode
, so going with the more verbose version.