Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update nalgebra requirement from 0.32 to 0.33 #249

Merged
merged 6 commits into from
Dec 2, 2024

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Jul 1, 2024

Updates the requirements on nalgebra to permit the latest version.

Changelog

Sourced from nalgebra's changelog.

[0.33.0] (23 June 2024)

Fixed

  • Fix a memory leak in Matrix::generic_resize.
  • Fix glm::is_null to check the vector magnitude instead of individual components.
  • Ensure that inverting a 4x4 matrix leaves it unchanged if the inversion fails.

Added

  • Add the glam-0.28 feature to enable conversion from/to types from glam v0.28.
  • Add a stack! macro for concatenating matrices. See #1375.

Modified

  • The cuda feature has been removed, as the toolchain it depends on is long abandoned.
  • Update to simba 0.9. See the changelog of simba for details.
  • Update the nalgebra-macros crate to syn 2.0.
  • Remove the scalar type T from the Allocator trait parameters. Instead of Allocator<T, R, C>, use the simpler Allocator<R, C>.

[0.32.6] (12 June 2024)

Added

  • Add the glam-0.27 feature to enable conversion from/to types from glam v0.27.

[0.32.5] (28 March 2024)

Fixed

  • Fix numerical issue on SVD with near-identity matrix.

[0.32.4] (19 Feb 2023)

Added

  • Add the glam-0.25 feature to enable conversion from/to types from glam v0.25.

[0.32.3] (09 July 2023)

Modified

  • Statically sized matrices are now serialized as tuples to match how serde serialized plain arrays.
  • Don’t require Scalar for matrix PartialEq and Eq.

Added

... (truncated)

Commits

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Jul 1, 2024
@YeungOnion
Copy link
Contributor

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/cargo/nalgebra-0.33 branch from 2421a49 to 5567ea3 Compare September 5, 2024 18:53
@FreezyLemon
Copy link
Contributor

Note: The msrv CI job will fail when updating a dependency without updating Cargo.lock.MSRV. Looks like a manual upgrade is needed here anyways, but wanted to let you know for the future

@YeungOnion
Copy link
Contributor

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/cargo/nalgebra-0.33 branch from 5567ea3 to 45d64bf Compare September 25, 2024 15:42
@YeungOnion
Copy link
Contributor

After fixing the breaking change in nalgebra (Allocator<T: Sized, D: Dim, D: Dim, ...> is now Allocator<D: Dim, D: Dim, ...> I see that nalgebra is using generic associated types, which is stabilized in rustc 1.65

GAT is interesting and 1.65 was released ≈22 months ago, which also has some other language features. Our MSRV approach is certainly lenient enough, so I don't see a reason to not, does anyone else?

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.70%. Comparing base (993a4b5) to head (cb55dca).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
src/distribution/internal.rs 66.66% 1 Missing ⚠️
src/distribution/multinomial.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
- Coverage   93.73%   93.70%   -0.04%     
==========================================
  Files          53       53              
  Lines       12010    11935      -75     
==========================================
- Hits        11258    11184      -74     
+ Misses        752      751       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FreezyLemon
Copy link
Contributor

1.65 sounds fine. I use the stats on lib.rs to get a rough picture of the ecosystem for things like this.

The MSRV lockfile needs a bump. I mentioned it in #268, but it might need to be added to the Cargo.toml or some developer doc somewhere:

This new lockfile however means that changes to the [dependencies] in Cargo.toml require updating the Cargo.lock.MSRV (CI is run with --locked, so a mismatch between Cargo.toml and Cargo.lock will result in a compile-time error) if you want CI not to fail. It's relatively easy to do if you have access to a nightly toolchain:
cargo +nightly update -Zmsrv-policy && cp Cargo.lock Cargo.lock.MSRV.

Copy link
Author

dependabot bot commented on behalf of github Nov 1, 2024

A newer version of nalgebra exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@FreezyLemon FreezyLemon mentioned this pull request Nov 24, 2024
doc(readme): add codecov badge

doc(readme): rewording and change suggestions for contributors
@YeungOnion YeungOnion force-pushed the dependabot/cargo/nalgebra-0.33 branch from 1b825da to 737125d Compare December 2, 2024 19:04
@YeungOnion YeungOnion force-pushed the dependabot/cargo/nalgebra-0.33 branch from 2ac6ac6 to cb55dca Compare December 2, 2024 19:33
@YeungOnion YeungOnion merged commit e7a995e into master Dec 2, 2024
10 checks passed
@YeungOnion YeungOnion deleted the dependabot/cargo/nalgebra-0.33 branch December 2, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants