Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/reintroduce-invalid-value-in-bis…
Browse files Browse the repository at this point in the history
…ect' into reintroduce-invalid-value-in-bisect

# Conflicts:
#	linerate/models/cigre207.py
  • Loading branch information
amundfr committed Jun 11, 2024
2 parents 5eaaedc + be5d802 commit d6adb1b
Showing 1 changed file with 2 additions and 10 deletions.
12 changes: 2 additions & 10 deletions linerate/models/cigre207.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,11 @@

class Cigre207(ThermalModel):
def __init__(
self,
span: Span,
weather: Weather,
time: Date,
include_diffuse_radiation: bool = True,
direct_radiation_factor: float = 1.0,
self, span: Span, weather: Weather, time: Date, include_diffuse_radiation: bool = True
):
super().__init__(span, weather)
self.time = time
self.include_diffuse_radiation = include_diffuse_radiation
self.direct_radiation_factor = direct_radiation_factor

@_copy_method_docstring(ThermalModel)
def compute_joule_heating(
Expand Down Expand Up @@ -55,9 +49,7 @@ def compute_solar_heating(
)
sin_eta = switch_cos_sin(cos_eta)

I_B = self.direct_radiation_factor * cigre207.solar_heating.compute_direct_solar_radiation(
sin_H_s, y
)
I_B = cigre207.solar_heating.compute_direct_solar_radiation(sin_H_s, y)
if self.include_diffuse_radiation:
I_d = cigre207.solar_heating.compute_diffuse_sky_radiation(I_B, sin_H_s)
F = self.span.ground_albedo
Expand Down

0 comments on commit d6adb1b

Please sign in to comment.