Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicting if-statement #2

Open
dtaliun opened this issue Jul 17, 2024 · 1 comment
Open

Conflicting if-statement #2

dtaliun opened this issue Jul 17, 2024 · 1 comment

Comments

@dtaliun
Copy link

dtaliun commented Jul 17, 2024

Hi Jonathon,

I think this condition will be always true when merging empirical dose files, because format_fields vector is filled out with "DS" and "LDS" a few lines above:

if (!format_fields.empty() && emp_cnt)

Also, a related question: Is there anything specific about stats to be aware of when merging empirical doses?

Thanks and best wishes!
Daniel

@jonathonl
Copy link
Contributor

Thanks for reporting this.

The one difference in the INFO fields when merging with hds-util vs imputed samples together is that the ER2 INFO field does not get recalculated (instead each sample batch ER2 is concatenated into a list). For the HDS files, ER2 cannot be recalculated because those files are missing the original genotypes. The LDS files could be recalculated, but metaMinimac doesn't use the ER2 INFO field, so it didn't seem necessary. I might change this in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants