Statamic 5: Simplify TestCase
#267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure which "earlier versions of Laravel" this is referring to but the test suite seems to pass without it so I presume it's no longer needed.
|
hmm since this has merged a lot of the tests arent performing any assertions:
|
|
I think that may be related to the PHPUnit version. I'll take a look today. |
ryanmitchell
added a commit
that referenced
this pull request
Jul 1, 2024
* Add upgrade note to readme * Missing update script * Correct file path to migration * Lets not exclude parent * Split forms and form submissions, provide Eloquent Submission Repository and Query Builder (#177) * Add upgrade note to readme * Begin split configs * Use form handle to relate, rather then a database id * Defer to core methods for retrieving submissions * Update fresh migrations and add migration for existing installs * Eloquent FormRepository * Fix migration * Dont force a model type or it can't be overwritten * Missing update script * Correct file path to migration * Lets not exclude parent * StyleCI * Actually run update script * Prep for Statamic 5 * Update dev dependencies * Try again * Meh * Remove deprecated test functions * static * Migrate PHP unit config * Fix migration * Fix tests to use handle instead of id * Bug fixes * Fix form listing bugs * Split migration publish tags (#266) * Split migration tags * fix everything * Merge branch '5.x-support' into split-migration-tags * Ignore `.phpunit.cache` --------- Co-authored-by: Ryan Mitchell <[email protected]> * Statamic 5: Simplify `TestCase` (#267) * Simplify `TestCase` * Remove `partialMock` method from `TestCase` I'm not sure which "earlier versions of Laravel" this is referring to but the test suite seems to pass without it so I presume it's no longer needed. * doesn't look like we're using this method either * The `ConsoleKernel` isn't needed * Make drivers opt-in, rather than opt-out (#268) * Eloquent driver should be opt-in, not opt-out * Swap all drivers to `eloquent` in our `TestCase` * Drop status on entries (#228) * Fix asset import bug * Drop status on entries * Revert "Fix asset import bug" This reverts commit 35ebe65. * Fix test * StyleCI * Revert * Proper update script * Make status nullable in down migration * Statamic 5: Docs Refresh (#254) * Initial docs refresh * Fix tpyo * Missing space --------- Co-authored-by: Ryan Mitchell <[email protected]> * Support mapped data columns * Add tests and fix test errors by freezing time * Update `AddonTestCase` import * Fix failing tests in `EntryQueryBuilderTest` (#275) * Fix failing tests in `EntryQueryBuilderTest` * dont need to freeze time for this test * 🍺 * 🍺 * Remove accidental testcase addition * Avoid make()-ing * Refactor out hooks * Add test coverage after bringin data into COLUMNS * Not array_keys * Add assertion that it doesnt save the field to the data column * 🍺 * Remove `@test` in favour of #[Test] * Remove ::hook calls * 🍺 --------- Co-authored-by: Duncan McClean <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request simplifies the addon's
TestCase, thanks to statamic/cms#9573.I've also removed the custom
partialMockmethod which no longer seems to be needed, theassertContainsHtmlassertion which we don't seem to be using anywhere and theConsoleKernelwhich also doesn't seem to be getting used.