Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with directory listing not returning all folders #224

Merged
merged 11 commits into from
Jan 2, 2024

Conversation

ryanmitchell
Copy link
Contributor

@ryanmitchell ryanmitchell commented Dec 12, 2023

This PR fixes an issue with the sync command and directory listing using the asset query builder. It also adds metaExists caching to the asset class to prevent multiple duplicate queries.

Closes #222
Closes #223

@sylvesterdamgaard
Copy link
Contributor

I tested this PR and it works as expected now! Thank you @ryanmitchell

@ryanmitchell ryanmitchell marked this pull request as ready for review January 2, 2024 08:26
@ryanmitchell ryanmitchell merged commit 6eccbb6 into statamic:master Jan 2, 2024
11 checks passed
@ryanmitchell ryanmitchell deleted the fix/directory-listing branch January 2, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Array to string conversion during eloquent sync Undefined array key "type"
2 participants