[4.x] Wire up global site picker groups #9565
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So it can be re-used throughout the JS.
|
Okay dang, the way we fetch and work with the sites list in the Entries/Terms sidebar is so wildly different than that Global Header that even with a unified config I can't untangle it. Closing this for now as it feels like too big of a rabbit hole and probably needs a wider view of the architecture. Stinks cuz I just wanna plop some HTML somewhere but it just ain't that simple. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a proof of concept working for the global site picker, but can't work out the best way to not duplicate a bunch of this logic in JS everywhere we need to use it. Could use an assist here.