[4.x] Corrects Stache problem on Windows #9537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #9524 by adjusting how Stache index paths are created on Windows.
The breaking change happened here:
https://github.com/statamic/cms/pull/6131/files#diff-b0fa04a7e478fa6c45835c964c3230f6d455a170013366c3b6657e01519e2915R136
This PR adjusts the created path from
->to-], but only on Windows (to not impact any existing paths and cause unnecessary update challenges for non-Windows users). I'm not sure how to add a test for this, but the existing tests pass and the issues outlined in #6131 seem to be working fine for me on Windows.