Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Exclude super when using a custom field #9536

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Conversation

jasonvarga
Copy link
Member

@jasonvarga jasonvarga commented Feb 16, 2024

When you're editing a user while logged in as a super user, we add a toggle for you. We also check your permission on the server side when saving it back onto the user.

However if you explicitly added your own super field onto the blueprint, $fields would contain super, and the value gets applied without running through the check.

This PR excludes it from the values so it has to go through the explicit check.

It also removes it from the "User information" step of the create form. If you're a super user, it'll already be on the "Roles & Groups" step.

@jasonvarga jasonvarga merged commit b5a5814 into 4.x Feb 16, 2024
36 checks passed
@jasonvarga jasonvarga deleted the custom-super-field branch February 16, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant