[4.x] Fix templates fieldtype when views are in a non-default location #9085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonvarga
requested changes
Nov 29, 2023
jasonvarga
approved these changes
Dec 7, 2023
This reverts commit e883f46.
jasonvarga
deleted the
fix/hard-coded-resources-directory-in-templates-fieldtype
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request attempts to fix an issue where the Templates fieldtype (which lets you select the template/layout for a collection), wouldn't return any templates after the site's views were moved outside of
resources/views.This PR re-works how the fieldtype finds available views - doing away with the folder/disk stuff, which I assume was ported from v2, to using PHP's
RecursiveDirectoryIterator.This allows us to search any of the configured paths for views (which can be configured in a project's
viewconfig file) without needing to setup filesystems for each of them.Happy for this PR to be re-worked if there's a better way of doing any of this.
Fixes #6643.