[4.x] Use RedirectIfAuthorized middleware on password reset & activate pages #9053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanmitchell
changed the title
duncanmcclean
approved these changes
Nov 23, 2023
- Use guard like in RedirectIfAuthenticated - Use guard guard clause (ha) so the bulky logic doesnt have to all sit in an conditional - Apply the flash message to both redirects. Maybe the frontend is using the session:error tag.
ryanmitchell
deleted the
fix/redirect-authenticated-users-on-password-reset-pages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
RedirectIfAuthorizedmiddleware to password reset & activate pages, so if a logged in user tries to visit those pages they will be redirected away.I've also updated RedirectIfAuthorized to check if the user can access the cp or not, if they can they are taken to it, and if they cant they are just taken to the homepage.
I think this closes #2521