Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Fix error in HasRequestedColumns trait on Laravel Vapor #9028

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

duncanmcclean
Copy link
Member

This pull request fixes an error that would only occur when using Statamic, on Laravel Vapor, with a AWS function URL.

After some digging and talking with Vapor support, I managed to figure out that AWS function URLs parse query parameters like title,status,slug as an array, instead of a string like they'd be parsed anywhere else.

This happens due to the way that AWS maps the requests internally. This isn't an issue for projects with custom domains or vanity domains where Vapor is able to workaround the issue.

Fixes #6868.

@jasonvarga jasonvarga merged commit 88c3cf7 into 4.x Nov 20, 2023
36 checks passed
@jasonvarga jasonvarga deleted the fix/has-requested-columns-error-on-vapor branch November 20, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collection not rendering when running on Vapor
2 participants