[5.x] Fix null coalescence operator evaluation #11221
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@marcorieser Brought up in discord that the null coalescence operator is not functioning like you'd expect.
It is expected that if the left side of the operator is not null then the right side would never be evaluated.
This is a contrived example that showcases the behavior:
Based on the order of operations and evaluation order, you'd expect the above to output:
But it instead outputs:
Because the right side of the operator is evaluated regardless of the left side being nullish.
This PR adds a test and fixes that behavior.