Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blockifier): replace entry_point_gas_cost with initial_budget #2247

Open
wants to merge 2 commits into
base: yonatank/blockifier/add_get_syscall_gas_cost_and_a_test_for_it
Choose a base branch
from

Conversation

Yonatan-Starkware
Copy link
Contributor

No description provided.

Copy link
Contributor Author

Yonatan-Starkware commented Nov 24, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@reviewable-StarkWare
Copy link

This change is Reviewable

@Yonatan-Starkware Yonatan-Starkware force-pushed the yonatank/blickifier/replace_entry_point_gas_cost_with_initial_budget branch from 0268017 to 295470e Compare November 24, 2024 12:43
@Yonatan-Starkware Yonatan-Starkware force-pushed the yonatank/blockifier/add_get_syscall_gas_cost_and_a_test_for_it branch from 8e62d52 to 3aa46ab Compare November 24, 2024 12:48
@Yonatan-Starkware Yonatan-Starkware force-pushed the yonatank/blickifier/replace_entry_point_gas_cost_with_initial_budget branch 2 times, most recently from 229d2c2 to 0fe8c7e Compare November 24, 2024 13:31
@Yonatan-Starkware Yonatan-Starkware force-pushed the yonatank/blockifier/add_get_syscall_gas_cost_and_a_test_for_it branch from 3aa46ab to dbae55c Compare November 24, 2024 13:33
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (yonatank/blockifier/add_get_syscall_gas_cost_and_a_test_for_it@d7b5bc8). Learn more about missing BASE report.

Additional details and impacted files
@@                                        Coverage Diff                                        @@
##             yonatank/blockifier/add_get_syscall_gas_cost_and_a_test_for_it    #2247   +/-   ##
=================================================================================================
  Coverage                                                                  ?   68.79%           
=================================================================================================
  Files                                                                     ?      109           
  Lines                                                                     ?    13987           
  Branches                                                                  ?    13987           
=================================================================================================
  Hits                                                                      ?     9622           
  Misses                                                                    ?     3954           
  Partials                                                                  ?      411           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Yonatan-Starkware Yonatan-Starkware force-pushed the yonatank/blockifier/add_get_syscall_gas_cost_and_a_test_for_it branch from dbae55c to 58755ee Compare November 24, 2024 14:22
@Yonatan-Starkware Yonatan-Starkware force-pushed the yonatank/blickifier/replace_entry_point_gas_cost_with_initial_budget branch from 0fe8c7e to e9b3ba4 Compare November 24, 2024 14:22
@Yonatan-Starkware Yonatan-Starkware force-pushed the yonatank/blockifier/add_get_syscall_gas_cost_and_a_test_for_it branch 2 times, most recently from d7b5bc8 to c0ec97c Compare November 24, 2024 14:57
@Yonatan-Starkware Yonatan-Starkware force-pushed the yonatank/blickifier/replace_entry_point_gas_cost_with_initial_budget branch from e9b3ba4 to d488544 Compare November 24, 2024 14:57
@Yonatan-Starkware Yonatan-Starkware force-pushed the yonatank/blickifier/replace_entry_point_gas_cost_with_initial_budget branch from d488544 to 49bcd57 Compare November 24, 2024 15:10
@Yonatan-Starkware Yonatan-Starkware force-pushed the yonatank/blockifier/add_get_syscall_gas_cost_and_a_test_for_it branch 3 times, most recently from 7bf221e to 03ea98e Compare November 24, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants