Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix emabled typo in Style/SafeNavigationChainLength #663

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

jeffbax
Copy link
Contributor

@jeffbax jeffbax commented Nov 12, 2024

Fixes a typo in the enabled flag in the 1.42.0 release

closes #662

@searls searls merged commit 1df0bc0 into standardrb:main Nov 13, 2024
4 checks passed
@jeffbax jeffbax deleted the fix-emabled-typo branch November 13, 2024 15:03
@mjankowski
Copy link
Contributor

Worth doing a 1.42.1 release for this?

@jeffbax
Copy link
Contributor Author

jeffbax commented Nov 15, 2024

Worth doing a 1.42.1 release for this?

I think it would be worth it, it is kind of annoying and probably a lot of people who haven't upgraded to the typo yet.

@mjankowski
Copy link
Contributor

Related - I wonder if we could have caught that issue. I know rubocop has a pretty robust linter/config-validator ... presumably there'd be some code-level "load out rules and verify no warnings present" sort of check we could add to suite...

pboling added a commit to omniauth/omniauth-identity that referenced this pull request Nov 16, 2024
@dan-manges
Copy link

+1 on a release to fix this. Otherwise this will print on every invocation of rubocop.

Warning: Style/SafeNavigationChainLength does not support Emabled parameter.
                                                                      
Supported parameters are:                                             
                                                                      
  - Enabled                                                                                                                                 
  - Max  

We downgraded standard to 1.41.0 on our project in the meantime.

@pboling
Copy link
Contributor

pboling commented Nov 18, 2024

This generates hundreds of lines of noise on my projects, which leads me to consider it a fully broken release. Noise is dangerous when I need to see real issues in my build.

@searls
Copy link
Contributor

searls commented Nov 18, 2024

Apologies for the delay in cutting a release. At least two gem owners (including myself) are currently traveling without access to a computer. Trying to get ahold of someone who can cut one

@camilopayan
Copy link
Contributor

v1.42.1 is out! Sorry for missing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo emabled in recent release for Style/SafeNavigationChainLength
6 participants